Don't suggest certain fixups (.field
, .await
, etc) when reporting errors while matching on arrays
#91098
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we have a type mismatch with a
cause.code
that is anObligationCauseCode::Pattern
, skip suggesting fixes like adding.await
or accessing a struct's.field
if the pattern'sroot_ty
differs from theexpected
ty. This occurs in situations like this:I think what's happening here is a layer of
[_; N]
is peeled off of both types and we end up seeing the mismatch between justS
and()
, but when we suggest a fixup, that applies to the expression with typeroot_ty
.Questions:
ObligationCauseCode
?ObligationCauseCode
s to check here?ObligationCauseCode
and comparingroot_ty
?Fixes #91058